Store images in a separate table and fetch them on demand #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes vaadin/starters#85 It also makes image handling smarter as the images are not loaded as part of an entity, which you rarely want
petrixh
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
In general as the target is/was to separate the images from the actual entity to improve Master view loading times (that don't show the images). The changes seem good.
A couple of small notes to maybe think about but nothing that should block merging.
Images are stored as binary in the DB, but presented in the UI as Base64 encoded. Is this intentional? Why not store them as b64?
- UserService#getProfilePictureUrl (is it actually an URL?)
- If the name is for demonstration purposes, maybe a comment indicating that this is where one could add their own logic to load the image from a source, File, Gravatar etc.. We use b64 here for simplicity...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes vaadin/starters#85
It also makes image handling smarter as the images are not loaded as part of an entity, which you rarely want